go-algorand 2.6.0-beta #2166
Merged
go-algorand 2.6.0-beta #2166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* TagCounter for recording stats about network tags
Modify the `eval()` to load the account data before the evaluation of each transaction group.
Trim StateDelta fields before storing
netgoal was failing to build network when the bootstrap files was missing.
The logfilter utility was not handling unit test panics correctly - the panic result was omitted from the output.
Improve the support for overlapping participation keys, and correct the participation key uniqueness. Highlights: * Keys used to be identified by account public address, first and last valid round. This wasn't that great. If you were to generate multiple participation keys for the same account, you could easily have few of them share the same parameters - making the algod vote with only one of them ( arbitrarily ). * When sending the votes, we were attempting to send the votes for all the participation keys that we had. If we had two participation keys valid with an overlapping range, we would vote for both of them ( and for the same account! ). This would not generate an issue on it's own, as we had a proper checking for the Vote and Selection keys on the verification side, but could lead to a malicious-like notifications in the log file. * Similar to the above, a newly added participation key would be used to vote right away, even before the 320 rounds have passed. This would cause the network to reject this vote. In this PR, I have changed the following: 1. `HasLiveKeys` - was removed. The method was not used anywhere in the codebase. 2. `Keys` was added a round number. This round number would be used for filtering a participation key that has the given round number between its first and last valid range. 3. The agreement `asyncPseudonode` would now cache the participation keys for a single round. This optimization wasn't done in a vacuum. The need for this came since we would add a database lookup for each account prior to returning the corresponding participation key. 4. The agreement now expect the `KeyManager` to have the `VotingKeys` method instead of the `Keys` method. This allow us to customize the node to provide a database lookup and ensure the voting keys available for the node are the one that would be accepted by the network.
Add unit tests to ledger/compactcert
remerge v2.5.6-stable
Previous PRs were advancing the config version from v16 to v17 needlessly. ( i.e. needlessly since the rel/beta is currently at v15 ) This PR merges back the changes from v17 into v16, and removes v17.
Test coverage for some functions in ledger/eval.go
`scripts/configure_dev.sh` can now install dependencies for Arch Linux.
When the recomputeBlockEvaluator runs, it tests all the pending transactions against the ledger to detect duplicate transactions ( which happen all the time; these aren't an issue ). The block evaluator reports the error by returning `*ledgercore.TransactionInLedgerError` and not `ledgercore.TransactionInLedgerError` as the code was testing against.
Add support for dynamic TEAL.
…#2137) The existing key registration transaction verification allows quite much flexibility on what is written to the account data. This PR adds few more constraints and would allow us to make certain assumptions regarding future key registration transactions.
…ction with no siblings. (#2152) A nil array is serialized to null which looks strange in the API response. Initialize to an empty array.
…ng (#2149) ledger: disable minimum balance check when not validating or generating
A change in 2.5.4 broke the upgrade behavior. When a node is upgraded with the new scripts, then algod -v updates, but the node doesn't update properly when you check curl the /versions endpoint.
|
It looks like |
bricerisingalgorand
approved these changes
May 20, 2021
Thanks for catching it. Will update. |
tsachiherman
pushed a commit
to tsachiherman/go-algorand
that referenced
this pull request
Jul 7, 2021
go-algorand 2.6.0-beta
PhearZero
pushed a commit
to PhearNet/crypto
that referenced
this pull request
Jan 17, 2025
go-algorand 2.6.0-beta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights
Changelog
General/Other
Teal
REST API
Tests
Catchup and Catchpoint
Ledger
Network
Goal
Transactions
Logger
netgoal
Participation Keys
Protocol Upgrade
This release does not contain a protocol upgrade.
Additional Resources
Test Plan
Standard release testing.
Verify reduced memory usage in higher traffic round processing.